Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix deprecation warnings, issue #294 #300

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix deprecation warnings, issue #294 #300

wants to merge 2 commits into from

Conversation

erwin
Copy link

@erwin erwin commented Jun 15, 2024

see: #294

Summary

Fixes #294

Checklist

Check out our PR guidelines for more details.

The following are mandatory for all PRs:

@fthobe
Copy link

fthobe commented Dec 5, 2024

@jarednorman can this be merged?

@fthobe fthobe mentioned this pull request Dec 5, 2024
Open
15 tasks
jarednorman
jarednorman requested changes Dec 11, 2024
View reviewed changes
Copy link
Member

@jarednorman jarednorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, I don't know what is going on with that second commit. There's commented out code and no explanation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jarednorman jarednorman jarednorman requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@erwin @fthobe @jarednorman