Fix/ae 2031 cypress tests fix #98
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
solita-juhohaa
force-pushed
the
fix/AE-2031-cypress-tests-fix
branch
11 times, most recently
from
03ddf53
to
846c3af
Compare
solita-juhohaa
force-pushed
the
fix/AE-2031-cypress-tests-fix
branch
19 times, most recently
from
6d0ec59
to
18d727e
Compare
The `--legacy-peer-deps` flag turned out to be also unnecessary
solita-juhohaa
force-pushed
the
fix/AE-2031-cypress-tests-fix
branch
from
01f464b
to
15552ad
Compare
solita-juhohaa
commented
Feb 14, 2024
muep
reviewed
Feb 14, 2024
etp-front/src/components/H/H2.svelte
Outdated
| @@ -8,4 +9,4 @@ | |||
| } | |||
| </style> | |||
|
|
|||
| <h2>{text}</h2> | |||
| <h2 {name} data-cy={name}>{text}</h2> | |||
There was a problem hiding this comment.
Of data-cy it is quite obvious that it is related to Cypress, but is that name attribute also intentional?
muep
approved these changes
Feb 14, 2024
Juholei
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.