New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use configured timeout in socket connection as well as reads #25

Open

kpmueller wants to merge 1 commit into solita:master from kpmueller:fix-connect_timeout

kpmueller commented Dec 17, 2021

this PR will set a connection timeout, in addition to the read timeout that is already done. (by breaking out socket.connect explicitly)

I didn't have another great way of doing it other than a nested try-with-resources, but I think it's a pretty standard way of doing it.


          use configured timeout in socket connection as well as reads

83c22be

kpmueller mentioned this pull request

timeout does only a read timeout, not a connect timeout #24

Open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet