Migration to .netstandard2.0 #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gonnagle
approved these changes
Apr 29, 2024
| <PackageReference Include="log4net" Version="2.0.17" /> | ||
| <PackageReference Include="Microsoft.CSharp" Version="4.7.0" /> | ||
| <PackageReference Include="System.Data.DataSetExtensions" Version="4.5.0" /> | ||
| <PackageReference Include="Newtonsoft.Json" Version="13.0.3" /> |
There was a problem hiding this comment.
The *.nuspec file seems to have hardcoded dep to Newtonsoft.Json version 7.0.1 - that probably needs to be updated also (not sure why it has no mention about lognet dep though o.O)
Been ages since last released nuget-packages though so a bit rusty on how .nuspec really works and what should be there are what not...
And how to test the packaging/publishing of the given nuget...
Gonnagle
suggested changes
Apr 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrated the project
Solita.Slack.Notifierto .Net Standard 2.0Updated nuget dependencies in
Solita.Slack.NotifierMigrated the project
Solita.Slack.Notifier.Teststo .Net 8Updated fixed the test URL with a temporary workspace.