Skip to content

fix: pass environment_offline through to the Gym actors - #24

Merged
anubhutivyas merged 1 commit into
nmp/customizerfrom
anubhutiv/fix-env-offline
Sep 7, 2026
Merged

fix: pass environment_offline through to the Gym actors#24
anubhutivyas merged 1 commit into
nmp/customizerfrom
anubhutiv/fix-env-offline

Conversation

@anubhutivyas

Copy link
Copy Markdown
Collaborator

What does this PR do ?

  • spinup_nemo_gym_actor rebuilds the sandboxed block from a fixed set of keys and omitted this one, so it silently took the model default: the compiled config said environment_offline: true while the sandbox got NMP_ENVIRONMENT_OFFLINE=0, and a wheels-v1 job reached for an index the deny-egress policy denies it.
  • The colocated NemoGymConfig call omitted it the same way.

Issues

List issues that this PR closes (syntax):

Usage

  • You can potentially add a usage example below
# Add a code snippet demonstrating how to use this

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you run the unit tests and functional tests locally? Visit our Testing Guide for how to run tests
  • Did you add or update any necessary documentation? Visit our Document Development Guide for how to write, build and test the docs.

Additional Information

  • ...

Signed-off-by: anubhutiv <anubhutiv@nvidia.com>
@anubhutivyas
anubhutivyas force-pushed the anubhutiv/fix-env-offline branch from b3975f6 to 07090a9 Compare September 7, 2026 18:47
@anubhutivyas
anubhutivyas merged commit 9932dc8 into nmp/customizer Sep 7, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants