Feature/parameter: Add parameter dialog #246
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buganini
force-pushed
the
feature/parameter
branch
from
c67b2c3
to
b1aa2cb
Compare
yungyuc
requested changes
Oct 21, 2023
cpp/modmesh/view/RParameter.cpp
Outdated
| namespace modmesh | ||
| { | ||
|
|
||
| static int int64V = 5566; |
There was a problem hiding this comment.
I think the global static data should be managed by a singleton. The singleton will make it possible for testing in Python (pytest).
cpp/modmesh/view/RParameter.cpp
Outdated
| static std::shared_ptr<pybind11::list> paramsList = nullptr; | ||
|
|
||
| template <typename T> | ||
| void addParam(const char *key, T *ptr) { |
There was a problem hiding this comment.
Would it be possible to store the parameter information in the hierarchical dynamic toggle:
Line 280 in 1bd0532
More information about modmesh toggles:
modmesh/cpp/modmesh/toggle/toggle.hpp
Line 220 in 1bd0532
|
|
yungyuc
requested changes
Oct 21, 2023
modmesh/params.py
Outdated
| @@ -0,0 +1,63 @@ | |||
| from PUI.PySide6 import * | |||
|
clang-format/flake8 issues are fixed |
|
I merged the code so that we can move on. A follow up ticket #247 is filed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requirement:
pip3 install QPUIQ==0.3