Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(imágenes_darkmode): Cambiar imágenes de los patrocinadores en darkmode #228

Merged
merged 3 commits into from
Apr 1, 2024

Conversation

1-echo
Copy link
Member

@1-echo 1-echo commented Mar 27, 2024

  • Referencia al Issue Utilizar versión clara de los logos cuando es necesario #128
  • Resumen de cambios:
    • Modificación al componente "SponsorInfoRouter.vue" para cambiar la imagen de acuerdo al valor de isDark.
    • Creación de un nuevo frontmatter 'cover_dark' que contiene la dirección de la imagen.
    • Modificaciones a los documentos .md de cada patrocinador que posee una imagen para el modo oscuro.

Copy link

netlify bot commented Mar 27, 2024

Deploy Preview for somosnlp ready!

Name Link
🔨 Latest commit e5b20e4
🔍 Latest deploy log https://app.netlify.com/sites/somosnlp/deploys/6608786f40231b000967a290
😎 Deploy Preview https://deploy-preview-228--somosnlp.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@1-echo 1-echo changed the title feat(imágenes_darkmode): feat(imágenes_darkmode): Cambiar imágenes de los patrocinadores en darkmode Mar 27, 2024
Copy link
Member

@mariagrandury mariagrandury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top @1-echo! Una implementación muy limpia gracias 👏

src/components/SponsorInfoRouter.vue Outdated Show resolved Hide resolved
Copy link
Member

@mariagrandury mariagrandury left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfecto, gracias!

@mariagrandury mariagrandury merged commit 934d50f into somosnlp:main Apr 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants