Skip to content

Commit

Permalink
Merge pull request kubernetes-sigs#2016 from zhouhao3/fix-ineffassign
Browse files Browse the repository at this point in the history
fix ineffectual assignment to err
  • Loading branch information
k8s-ci-robot authored May 18, 2021
2 parents 8409bd5 + 45d9714 commit 07a29df
Showing 1 changed file with 6 additions and 0 deletions.
6 changes: 6 additions & 0 deletions test/framework/helm/release_manager.go
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,9 @@ func (m *defaultReleaseManager) InstallRelease(chartRepo string, chartName strin
installAction.ReleaseName = releaseName

cp, err := installAction.ChartPathOptions.LocateChart(chartName, cli.New())
if err != nil {
return nil, err
}
chartRequested, err := loader.Load(cp)
if err != nil {
return nil, err
Expand All @@ -85,6 +88,9 @@ func (m *defaultReleaseManager) UpgradeRelease(chartRepo string, chartName strin
upgradeAction.Wait = true

cp, err := upgradeAction.ChartPathOptions.LocateChart(chartName, cli.New())
if err != nil {
return nil, err
}
chartRequested, err := loader.Load(cp)
if err != nil {
return nil, err
Expand Down

0 comments on commit 07a29df

Please sign in to comment.