Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

allow doctrine/persistence ^4.0 #1826

Merged
merged 1 commit into from
Jan 31, 2025
Merged

allow doctrine/persistence ^4.0 #1826

merged 1 commit into from
Jan 31, 2025

Conversation

dmaicher
Copy link
Contributor

@dmaicher dmaicher commented Jan 31, 2025 •
edited by VincentLanglet
Loading

Subject

I am targeting this branch, because its BC..

Changelog

### Added
- Support for `doctrine/persistence` ^4.0

dmaicher
dmaicher commented Jan 31, 2025
View reviewed changes
tests/App/AppKernel.php
@@ -56,6 +57,12 @@ public function registerBundles(): iterable
new TwigBundle(),
new DoctrineFixturesBundle(),
];

if (class_exists(StimulusBundle::class)) {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needed due to https://github.com/sonata-project/SonataAdminBundle/pull/8230/files#diff-d2ab9925cad7eac58e0ff4cc0d251a937ecf49e4b6bf57f8b95aab76648a9d34R60

@dmaicher
Copy link
Contributor Author

dmaicher commented Jan 31, 2025 •
edited
Loading

Tested locally with composer req doctrine/persistence "4.0 as 3.3.3" and with dev dependencies. Tests are passing.

For installing 4.0 on CI this needs fixes and releases for

$ composer why-not doctrine/persistence ^4.0
doctrine/doctrine-bundle           2.13.2 requires doctrine/persistence (^2.2 || ^3)   
doctrine/doctrine-fixtures-bundle  4.0.0  requires doctrine/persistence (^2.4 || ^3.0) 
sonata-project/doctrine-extensions 2.4.1  requires doctrine/persistence (^3.0.2)       
sonata-project/entity-audit-bundle 1.18.0 requires doctrine/persistence (^3.0)

@dmaicher dmaicher marked this pull request as ready for review January 31, 2025 19:27
@dmaicher dmaicher requested a review from a team January 31, 2025 19:27
VincentLanglet
VincentLanglet approved these changes Jan 31, 2025
View reviewed changes
composer.json
@@ -47,8 +47,9 @@
"twig/twig": "^3.0"
},
"require-dev": {
"ext-pdo_sqlite": "*",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is it now needed ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well running tests without it fails so I thought let's make it explicit?

@VincentLanglet VincentLanglet merged commit 6369dcb into sonata-project:4.x Jan 31, 2025
27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VincentLanglet VincentLanglet VincentLanglet approved these changes

Assignees
No one assigned
Labels
dependencies minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmaicher @VincentLanglet