Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not send composer v1 provider-list in provider field anymore #159

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pascalheidmann
Copy link

This pull request makes the following changes:

  • removes package list from packages.json endpoint as composerV2 does not use it

@stklcode
Copy link
Contributor

stklcode commented Oct 1, 2024

Did v1 actually use it? Wondering if providers was ever correct in this place. Docs name provider-includes which points to JSON includes that contain the providers list, but no list directly in the repo spec.

We still provide providers-url for v1, so honestly I can’t remember if it ever made any difference or if providers was always ignored.

Nevertheless, if we do not generate the providers from packages, we also don’t have to parse the package list on proxy repos, which is optional and not available on all repos (see #150).

While refactoring this I also eliminated providers on hosted repos and added support for available-package(-pattern)s instead (see #165)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants