Skip to content

Update for compatibility with Sketch 2025.1 and after #161

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

Update for compatibility with Sketch 2025.1 and after #161

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8060a0f
`MSPage.rulerBase` is read-only starting in 2025.1
jpedroso Jul 19, 2025
49f6af0
Use MSLayerGroup's layers() instead of children()
jpedroso Jul 19, 2025
360d466
Update zoom to fit layers in canvas after Sketch 2025.1
jpedroso Jul 19, 2025
782b9e4
Fix crash setting group name text color
jpedroso Jul 19, 2025
ec63aa4
Remove MSLayerGroup.hasClickThrough no longer exists
jpedroso Jul 19, 2025
74d9a29
Set sizing on title text layers to fit contents
jpedroso Jul 19, 2025
f695285
Resize title group to fit layers
jpedroso Jul 19, 2025
fd6463a
Use `childrenIncludingSelf(true)` as replacement for `children()` ins…
jpedroso Jul 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Symbol Organizer.sketchplugin/Contents/Sketch/functions.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ function createTextStyle(styleData) {
textStyle.setLineHeight(styleData.lineHeight);
textStyle.setTextAlignment(styleData.textAlignment);
textStyle.setFontPostscriptName(styleData.fontFace);
textStyle.setTextColor(MSImmutableColor.colorWithSVGString("#" + styleData.fontColor));
textStyle.setTextColor(MSColor.colorWithHex_alpha("#" + styleData.fontColor, 1))

return textStyle;
}
Expand Down Expand Up @@ -328,7 +328,7 @@ function getExemptSymbols() {

while (page = pageLoop.nextObject()) {
var predicate = NSPredicate.predicateWithFormat("className == %@ && overrides != nil","MSSymbolInstance"),
instancesWithOverrides = page.children().filteredArrayUsingPredicate(predicate),
instancesWithOverrides = page.childrenIncludingSelf(true).filteredArrayUsingPredicate(predicate),
loop = instancesWithOverrides.objectEnumerator(),
instance;

Expand Down
21 changes: 16 additions & 5 deletions Symbol Organizer.sketchplugin/Contents/Sketch/script.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,12 @@ var organize = function(context,type) {
var groupLayout = createGroupObject(symbols,layoutSettings.groupDepth);

// Reset page origin
page.setRulerBase(CGPointMake(0,0));
var hRulerData = page.horizontalRulerData() || MSRulerData.new();
var vRulerData = page.verticalRulerData() || MSRulerData.new();
hRulerData.setBase(0);
page.setHorizontalRulerData(hRulerData);
vRulerData.setBase(0);
page.setVerticalRulerData(vRulerData);

// If user wants to display group titles...
if (layoutSettings.displayTitles == 1) {
Expand Down Expand Up @@ -159,7 +164,6 @@ var organize = function(context,type) {
titleGroup.frame().setX((layoutSettings.sortDirection == 0) ? 0 : -xPad);
titleGroup.frame().setY((layoutSettings.sortDirection == 0) ? -(offsetHeight+yPad) : 0);
titleGroup.setIsLocked(true);
titleGroup.setHasClickThrough(true);
}

// Set tracker/counters
Expand Down Expand Up @@ -190,8 +194,11 @@ var organize = function(context,type) {

// Create screen title
var screenTitle = MSTextLayer.new();
screenTitle.setHorizontalSizing(1);
screenTitle.setVerticalSizing(1);
screenTitle.setStringValue(groupLayout[i]["prefix"]);
screenTitle.setName(groupLayout[i]["prefix"]);
screenTitle.adjustFrameToFit();

if (titleTextAlign == 0) {
screenTitle.frame().setY(titleTextY);
Expand Down Expand Up @@ -290,7 +297,9 @@ var organize = function(context,type) {
page.addLayers([titleGroup]);

// Resize title group
if (sketch.version.sketch > 52) {
if (sketch.version.sketch > 2025) {
titleGroup.resizeToFitChildren();
} else if (sketch.version.sketch > 52) {
titleGroup.fixGeometryWithOptions(0);
} else {
titleGroup.resizeToFitChildrenWithOption(0);
Expand All @@ -303,7 +312,9 @@ var organize = function(context,type) {
// If user wants to zoom out...
if (layoutSettings.zoomOut == 1) {
// Adjust view
if (sketch.version.sketch > 64) {
if (sketch.version.sketch > 2025) {
context.document.canvasView().centerLayersInCanvas();
} else if (sketch.version.sketch > 64) {
context.document.canvasView().zoomToFitRect(page.contentBounds());
} else {
context.document.contentDrawView().zoomToFitRect(page.contentBounds());
Expand All @@ -324,7 +335,7 @@ var remove = function(context) {
count = 0;

var predicate = NSPredicate.predicateWithFormat("className == %@ && isSafeToDelete == 1","MSSymbolMaster"),
symbols = context.document.currentPage().children().filteredArrayUsingPredicate(predicate);
symbols = context.document.currentPage().childrenIncludingSelf(true).filteredArrayUsingPredicate(predicate);

symbols.forEach(function(symbol){
if (exemptSymbols.indexOf(String(symbol.symbolID())) == -1) removeSymbols.push(symbol);
Expand Down