Check 'hostname' instead of 'hostname -s' in sethostname #20404
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
I noticed that /etc/hosts file is getting constantly filled with new records when dhclient is enabled.
DHCP is providing FQDN, while we check only against short hostname and this will never match.
And DHCP offer:
sethostname6
also useshostname
instead ofhostname -s
Work item tracking
How I did it
I changed
current_host_name
variable to behostname
value instead ofhostname -s
How to verify it
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
202405
Description for the changelog
Change
current_host_name
value tohostname
instead ofhostname -s
in sethostname fileLink to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)