PVST Feature commit #20417
Open
PVST Feature commit #20417
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
divyachandralekha
requested review from
qiluo-msft,
xumia and
lguohan
as code owners
praveenraja1
reviewed
Oct 8, 2024
| $(DOCKER_STP)_LOAD_DOCKERS = $(DOCKER_CONFIG_ENGINE_BULLSEYE) | ||
|
|
||
| $(DOCKER_STP)_CONTAINER_NAME = stp | ||
| $(DOCKER_STP)_RUN_OPT += --privileged -t |
There was a problem hiding this comment.
Generally giving host system privileges to docker is not a good idea due to security reasons,
Is it possible to check if access needed by stp daemon are met by doing selective capability additions, something like below,
$(DOCKER_STP)_RUN_OPT += -t --cap-add=NET_ADMIN --cap-add=SYS_ADMIN --cap-add=NET_BROADCAST
sutharsansr
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Added new STP docker and rules to compile STP
Added libevent required for STP
How to verify it
After this PR STP docker will be available