Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with getting midplane bridge IP address #20422

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

oleksandrivantsiv
Copy link
Collaborator

@oleksandrivantsiv oleksandrivantsiv commented Oct 4, 2024

Why I did it

Fix the issue with getting a midplane bridge IP address.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Use the right variable name.

How to verify it

On the Smart Switch device ZMQ from the NPU should be able to connect to the orchagent on the DPU,

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@oleksandrivantsiv oleksandrivantsiv marked this pull request as ready for review October 5, 2024 02:37
@prsunny prsunny requested a review from liuh-80 October 7, 2024 22:57
@oleksandrivantsiv
Copy link
Collaborator Author

@prsunny, @liuh-80 can we merge this PR?

@liuh-80
Copy link
Contributor

liuh-80 commented Oct 9, 2024

@prsunny, @liuh-80 can we merge this PR?

Yes, please, BTW I have another PR which will change ZMQ bind to midplane mgmt interface, which is because the IP address may change by DHCP:

#20352

@prsunny
Copy link
Contributor

prsunny commented Oct 9, 2024

I see the same change in 20352 PR. Should we close this and merge the other one?

@liuh-80
Copy link
Contributor

liuh-80 commented Oct 10, 2024

I see the same change in 20352 PR. Should we close this and merge the other one?

This PR no longer necessary, because #20352 already change code, ZMQ will bind to interface name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants