Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bind ASIC database instances to midplane IPs #20803

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

vivekverma-arista
Copy link
Contributor

@vivekverma-arista vivekverma-arista commented Nov 14, 2024

Why I did it

Add support for aggregate VOQ counters.

Work item tracking
  • Microsoft ADO (number only):

How I did it

Bound ASIC redis database instances on linecards to IPs in midplane subnet (in addition to lo and docker network IPs) so that they are accessible from supervisor and queuestat can access those and aggregate VOQ counters.

CLI changes: #3617

How to verify it

Which release branch to backport (provide reason below if selected)

  • 201811
  • 201911
  • 202006
  • 202012
  • 202106
  • 202111
  • 202205
  • 202211
  • 202305

Tested branch (Please provide the tested image version)

Description for the changelog

Link to config_db schema for YANG module changes

A picture of a cute animal (not mandatory but encouraged)

@kenneth-arista
Copy link
Contributor

@arlakshm for awareness

@kenneth-arista
Copy link
Contributor

Tracking issue: sonic-net/SONiC#1543

@arlakshm
Copy link
Contributor

Please add more details how what problem is PR is trying to solve

@mssonicbld
Copy link
Collaborator

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Contributor

@vmittal-msft vmittal-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure these changes don't impact T0/T1 device.

@vivekverma-arista
Copy link
Contributor Author

Please make sure these changes don't impact T0/T1 device.

We have this merged internally for a few weeks now and we haven't seen any regression on T0/T1 devices.

Copy link
Contributor

@judyjoseph judyjoseph left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@judyjoseph
Copy link
Contributor

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@judyjoseph
Copy link
Contributor

@rlhui could you help merge

@rlhui
Copy link
Contributor

rlhui commented Feb 28, 2025

@rlhui could you help merge

builds not passing

@judyjoseph
Copy link
Contributor

/azp run Azure.sonic-buildimage

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

7 participants