Fix sonic-bgp-neighbor.yang to use backreference for vlan int and allow subint #21212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run Azure.sonic-buildimage |
The committers listed above are authorized under a signed CLA. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run Azure.sonic-buildimage |
joolli
force-pushed
the
bgp-neighbor_vlan_and_subint_fix
branch
from
f2e543b to
8fa8f9d
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
1 similar comment
|
Azure Pipelines successfully started running 1 pipeline(s). |
…face validation instead of regex and add subinterface support. Signed-off-by: Julius <[email protected]>
joolli
force-pushed
the
bgp-neighbor_vlan_and_subint_fix
branch
from
8fa8f9d to
50e6784
Compare
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I don't know how to resolve the ms_conflict check failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #18965
Why I did it
I couldn't add subinterfaces as neighbors when using bgp-unnumbered (IPv6 link-local neighbors)
How to verify it
Use
sudo config bgp-neighbor bgp-neighbor-list addand use a subinterface as an neighbor or a vlan SVI.Tested branch (Please provide the tested image version)
Description for the changelog
Add a backreference to the VLAN yang for a unified validation and add subinterface validation to bgp-neighbor yang model
Link to config_db schema for YANG module changes
Not sure if it's applicable. Can't find a reference to bgp neighbor yang definitions for frr-mgmt-framework in
sonic-yang-models/doc/Configuration.md.