libyang3-py3: test crash seen in Trixie #23229
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There is an internal Python CFFI pointer that gets invalidated in a test case due to the internal object being mutated. This test case appears to be malformed and makes incorrect assumptions. Nothing here in particular appears to be actually related to Trixie so it isn't clear why it shows up. The feature being tested is also in a code path that is not used at all by SONiC. CESNET/libyang-python#141 Signed-off-by: Brad House <[email protected]>
Collaborator
|
/azp run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Collaborator
|
rebased to force a rebuild since there were spurious test failures |
saiarcot895
approved these changes
Jul 14, 2025
Contributor
|
@lguohan - please help merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Issue #23147 noted test case failures of the recent libyang3-py3 code test cases during compilation when using Trixie.
There is an internal Python CFFI pointer that gets invalidated in a test case due to the internal object being mutated. This test case appears to be malformed and makes incorrect assumptions.
Nothing here in particular appears to be actually related to Trixie so it isn't clear why it shows up. The feature being tested is also in a code path that is not used at all by SONiC.
Work item tracking
How I did it
Triaged underlying issue and submitted upstream PR CESNET/libyang-python#141 to fix the issue
How to verify it
Build SONiC with Trixie and observe libyang3-py3 compiles as expected.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
master as of 20250706
Description for the changelog
libyang3-py3: test crash seen in Trixie
Link to config_db schema for YANG module changes
N/A
A picture of a cute animal (not mandatory but encouraged)
Fixes #23147
Signed-off-by: Brad House [email protected]