change radius authentication default #112
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The committers listed above are authorized under a signed CLA. |
|
@qiluo-msft could you please review? |
|
@qiluo-msft , Can you please review ? |
qiluo-msft
reviewed
May 13, 2024
| @@ -63,7 +63,7 @@ RADIUS_SERVER_AUTH_PORT_DEFAULT = "1812" | |||
| RADIUS_SERVER_PASSKEY_DEFAULT = "" | |||
| RADIUS_SERVER_RETRANSMIT_DEFAULT = "3" | |||
| RADIUS_SERVER_TIMEOUT_DEFAULT = "5" | |||
| RADIUS_SERVER_AUTH_TYPE_DEFAULT = "pap" | |||
There was a problem hiding this comment.
Do you have another PR to change yang model? https://github.com/sonic-net/sonic-buildimage/blob/d9e62560fdd0b67ebab99e54a0949e4684a6ee50/src/sonic-yang-models/yang-models/sonic-system-radius.yang#L70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Due to a potential security vulnerability in the Radius ciphers, we have moved to mschapv2 as it is the least vulnerable one out of the available ciphers in Radius.
How I did
changed the RADIUS_SERVER_AUTH_TYPE_DEFAULT in hostcfgd