[action] [PR:145] Fix modify_single_file generate empty file issue (#145) #151
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix hostcfgd modify_single_file method generates empty file issue #### Why I did it Fix hostcfgd modify_single_file method generates empty file issue: sonic-net/sonic-buildimage#19748 In the original code, there are 2 'mv' commands to backup and copy new file, if hostcfgd crash between those 2 commands, the original file will be removed, then when hostcfgd restart later, it will generate a empty file. The issue can be fix by use cp command. ##### Work item tracking - Microsoft ADO: 29064569 #### How I did it Replace 'mv' command to 'cp' command #### How to verify it Manually verified. Pass all test case. <!-- If PR needs to be backported, then the PR must be tested against the base branch and the earliest backport release branch and provide tested image version on these two branches. For example, if the PR is requested for master, 202211 and 202012, then the requester needs to provide test results on master and 202012. --> #### Which release branch to backport (provide reason below if selected) <!-- - Note we only backport fixes to a release branch, *not* features! - Please also provide a reason for the backporting below. - e.g. - [x] 202006 --> - [ ] 201811 - [ ] 201911 - [ ] 202006 - [ ] 202012 - [ ] 202106 - [ ] 202111 - [ ] 202205 - [ ] 202211 - [ ] 202305 #### Tested branch (Please provide the tested image version) <!-- - Please provide tested image version - e.g. - [x] 20201231.100 --> will updated with this PR image later. - [] SONiC.master-16482.360728-2c8b4066f #### Description for the changelog Fix hostcfgd modify_single_file method generates empty file issue #### Link to config_db schema for YANG module changes <!-- Provide a link to config_db schema for the table for which YANG model is defined Link should point to correct section on https://github.com/Azure/sonic-buildimage/blob/master/src/sonic-yang-models/doc/Configuration.md --> #### A picture of a cute animal (not mandatory but encouraged)
|
Original PR: #145 |
9 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix hostcfgd modify_single_file method generates empty file issue
Why I did it
Fix hostcfgd modify_single_file method generates empty file issue: sonic-net/sonic-buildimage#19748
In the original code, there are 2 'mv' commands to backup and copy new file, if hostcfgd crash between those 2 commands, the original file will be removed, then when hostcfgd restart later, it will generate a empty file.
The issue can be fix by use cp command.
Work item tracking
How I did it
Replace 'mv' command to 'cp' command
How to verify it
Manually verified.
Pass all test case.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
will updated with this PR image later.
Description for the changelog
Fix hostcfgd modify_single_file method generates empty file issue
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)