Handle NotImplementedError in determine-reboot-cause that will be thrown on VS Chassis platform #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lementedError that will be thrown on VS Chassis platform
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
BYGX-wcr
changed the title
|
/azp run |
abdosi
reviewed
Feb 5, 2025
| @@ -142,7 +145,7 @@ def get_reboot_cause_dict(previous_reboot_cause, comment, gen_time): | |||
| If user issused a command to reboot device, then user, command and time will be | |||
| stored into a dictionary. | |||
|
|
|||
| If device was rebooted due to the kernel panic, then the string `Kernel Panic` | |||
| If device was rebooted due to the kernel panic, then the string `Kernel Panic` | |||
There was a problem hiding this comment.
why we are seeing whitespace diff
There was a problem hiding this comment.
My editor will automatically trim trailing white spaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On VS Chassis platform, the sonic_platform package is not implemented since there is no hardware associated with it. So the chassis.get_reboot_cause API will throw NotImplementedError. I added the code change to handle this exception and return the reboot cause as "N/A" in this case.