[Logrotate] Update log rotate configuration via ConfigDB #61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
10 tasks
|
Tests will fail until sonic-net/sonic-swss-common#783 will be merged |
dgsudharsan
suggested changes
May 18, 2023
|
/azpw run sonic-net.sonic-host-services |
|
/AzurePipelines run sonic-net.sonic-host-services |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@fastiuk Please merge latest master code to trigger Semgrep. |
fastiuk
force-pushed
the
dev-logrotate-config
branch
from
f091ec7
to
44f686b
Compare
fastiuk
force-pushed
the
dev-logrotate-config
branch
from
12cd2ff
to
6a159b0
Compare
SviatoslavBoichuk
force-pushed
the
dev-logrotate-config
branch
from
6a159b0
to
0601c94
Compare
|
@dgsudharsan any further comments? |
dgsudharsan
suggested changes
Jul 10, 2024
|
Tests will fail until sonic-net/sonic-swss-common#783 will be merged |
* Handle changes in LOGGING table Signed-off-by: Yevhen Fastiuk <[email protected]>
fastiuk
force-pushed
the
dev-logrotate-config
branch
from
b6ce8af
to
94f9d2f
Compare
|
I had to force push due to EasyCLA |
|
Tests will fail until sonic-net/sonic-swss-common#783 will be merged |
maipbui
reviewed
Oct 7, 2024
| syslog.syslog(syslog.LOG_INFO, | ||
| f'Set logging file {key} config: {data}') | ||
| try: | ||
| run_cmd('sudo systemctl restart logrotate-config', True, True) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends-on #783
This PR brings functionality that allows us to update the log rotation configs by writing to the LOGGING table of ConfigDB