Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[featured] Add support for dhcp_server in featured #85

Closed
wants to merge 1 commit into from

Conversation

yaqiangz
Copy link

@yaqiangz yaqiangz commented Nov 16, 2023

Why I did it

Add support in featured for Port Based IPv4 DHCP Server, HLD: sonic-net/SONiC#1282.
dhcp_server feature need dhcp_relay, and processes running in dhcp_relay container started by supervisord would change due to state of dhcp_server feature, hence we need to restart dhcp_relay service when dhcp_server feature is disabled/enabled.

Work item tracking
  • Microsoft ADO (number only): 25723645

How I did it

  1. Add logic to restart dhcp_relay when state of dhcp_server feature change.
  2. Add unit test

How to verify it

  1. Unit test passed
  2. Manually test in device, dhcp_relay container was restarted when state of dhcp_server feature change.

@yaqiangz yaqiangz force-pushed the master_dhcp_server branch 11 times, most recently from 5b7d31b to 03eac20 Compare November 16, 2023 07:41
@yaqiangz yaqiangz marked this pull request as ready for review November 16, 2023 08:18
@yaqiangz yaqiangz requested a review from Blueve November 16, 2023 08:18
@yaqiangz
Copy link
Author

No need

@yaqiangz yaqiangz closed this Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant