Fix default route race condition UT #258
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Longxiang Lyu <[email protected]>
lolyu
changed the title
yxieca
approved these changes
Jun 26, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-linkmgrd
that referenced
this pull request
Jun 26, 2024
Signed-off-by: Longxiang Lyu <[email protected]>
|
Cherry-pick PR to 202311: #259 |
mssonicbld
pushed a commit
that referenced
this pull request
Jun 26, 2024
Signed-off-by: Longxiang Lyu <[email protected]>
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
lolyu
added a commit
to lolyu/sonic-linkmgrd
that referenced
this pull request
Aug 23, 2024
Signed-off-by: Longxiang Lyu <[email protected]>
lolyu
added a commit
that referenced
this pull request
Aug 23, 2024
Approach What is the motivation for this PR? Fix the UT failure introduced by #254. The failure is due to that, the wait time for the two default route handlers to finish is 10ms, which is not sufficient on some build image agents which has limited CPU resource. Signed-off-by: Longxiang Lyu [email protected] Work item tracking Microsoft ADO (number only): 28471183 How did you do it? Let's increase the wait time to 8s. How did you verify/test it? UT passed. Any platform specific information? Documentation
|
@lolyu Can you please file a direct PR for 202405 branch to address the conflict? |
lolyu
added a commit
to lolyu/sonic-linkmgrd
that referenced
this pull request
Aug 27, 2024
Signed-off-by: Longxiang Lyu <[email protected]>
4 tasks
StormLiangMS
pushed a commit
that referenced
this pull request
Aug 28, 2024
What is the motivation for this PR? Cherry-pick #258 into 202305. Signed-off-by: Longxiang Lyu [email protected]
bingwang-ms
added
Included in 202405 Branch
and removed
Cherry Pick Conflict_202405
Request for 202405 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Approach
What is the motivation for this PR?
Fix the UT failure introduced by #254.
The failure is due to that, the wait time for the two default route handlers to finish is 10ms, which is not sufficient on some build image agents which has limited CPU resource.
Signed-off-by: Longxiang Lyu [email protected]
Work item tracking
How did you do it?
Let's increase the wait time to 8s.
How did you verify/test it?
UT passed.
Any platform specific information?
Documentation