Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Snappi] cleanup unused code after PR #14127 #16015

Open
sdszhang opened this issue Dec 11, 2024 · 1 comment
Open

[Snappi] cleanup unused code after PR #14127 #16015

sdszhang opened this issue Dec 11, 2024 · 1 comment
Labels
Help Wanted Triaged

Comments

@sdszhang
Copy link
Contributor

Initially the multidut snappi were added with different infrastructure code.
after PR #14127, they are not needed anymore, need to clean up these code.

e.g. the following two functions are not needed anymore, need to be removed:
get_multidut_tgen_peer_port_set
get_multidut_snappi_ports

there should be more code to be removed, please check and clean them up. Thanks.
@sdszhang
Copy link
Contributor Author

@selldinesh

selldinesh pushed a commit to selldinesh/sonic-mgmt that referenced this issue Dec 11, 2024
[sonic-net#16015 Fix]: Cleaning up unused code from snappi_fixtures
4ffacc9
@selldinesh selldinesh mentioned this issue Dec 11, 2024
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Help Wanted Triaged
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@yxieca @sdszhang