Skip to content

[#16015 Fix]: Cleaning up unused code from snappi_fixtures #16026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

selldinesh
Copy link
Contributor

Description of PR

Summary: Removing unused fixtures: get_multidut_tgen_peer_port_set and
get_multidut_snappi_ports from snappi_fixtures.py
Fixes # (issue)
#16015

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

How did you do it?

deleted the code

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

linux-foundation-easycla bot commented Dec 11, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

  • ✅ login: selldinesh / name: Dinesh Kumar Sellappan (4ffacc9)

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@sdszhang
Copy link
Contributor

@amitpawar12 for viz.

@sdszhang
Copy link
Contributor

@selldinesh can you sign the CLA?

Copy link
Contributor

@sdszhang sdszhang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yejianquan yejianquan merged commit baf48c2 into sonic-net:master Jan 14, 2025
25 checks passed
mssonicbld pushed a commit to mssonicbld/sonic-mgmt that referenced this pull request Jan 14, 2025
…onic-net#16026)

Description of PR
Summary: Removing unused fixtures: get_multidut_tgen_peer_port_set and
get_multidut_snappi_ports from snappi_fixtures.py
Fixes # (issue)
sonic-net#16015

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 Test case(new/improvement)
Back port request
 202012
 202205
 202305
 202311
 202405
Approach
What is the motivation for this PR?
How did you do it?
deleted the code

co-authorized by: [email protected]
@mssonicbld
Copy link
Collaborator

Cherry-pick PR to 202411: #16506

mssonicbld pushed a commit that referenced this pull request Jan 14, 2025
Description of PR
Summary: Removing unused fixtures: get_multidut_tgen_peer_port_set and
get_multidut_snappi_ports from snappi_fixtures.py
Fixes # (issue)
#16015

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 Test case(new/improvement)
Back port request
 202012
 202205
 202305
 202311
 202405
Approach
What is the motivation for this PR?
How did you do it?
deleted the code

co-authorized by: [email protected]
yejianquan pushed a commit to yejianquan/sonic-mgmt that referenced this pull request Jan 17, 2025
…onic-net#16026)

Description of PR
Summary: Removing unused fixtures: get_multidut_tgen_peer_port_set and
get_multidut_snappi_ports from snappi_fixtures.py
Fixes # (issue)
sonic-net#16015

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 Test case(new/improvement)
Back port request
 202012
 202205
 202305
 202311
 202405
Approach
What is the motivation for this PR?
How did you do it?
deleted the code

co-authorized by: [email protected]
yejianquan added a commit to yejianquan/sonic-mgmt that referenced this pull request Jan 17, 2025
[sonic-net#16015 Fix]: Cleaning up unused code from snappi_fixtures (sonic-net#16026)

Description of PR
Summary: Removing unused fixtures: get_multidut_tgen_peer_port_set and get_multidut_snappi_ports from snappi_fixtures.py Fixes # (issue) sonic-net#16015

Approach
What is the motivation for this PR?
How did you do it?
deleted the code

co-authorized by: [email protected]
wangxin pushed a commit to wangxin/sonic-mgmt that referenced this pull request Feb 21, 2025
…onic-net#16026)

Description of PR
Summary: Removing unused fixtures: get_multidut_tgen_peer_port_set and
get_multidut_snappi_ports from snappi_fixtures.py
Fixes # (issue)
sonic-net#16015

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 Test case(new/improvement)
Back port request
 202012
 202205
 202305
 202311
 202405
Approach
What is the motivation for this PR?
How did you do it?
deleted the code

co-authorized by: [email protected]
wangxin pushed a commit to wangxin/sonic-mgmt that referenced this pull request Feb 21, 2025
Merge 202405 branch in as of 12:23pm 20/01/2025 AEST

b118611 (HEAD -> merge/202405) Use alternate check for reboot for T2 after reboot with REBOOT_TYPE_POWEROFF (sonic-net#16348)
0e0e898 flap interface after sfp reset (sonic-net#16375)
41e2b2f Temporarily skip lpmode test for some transceivers with known issue (sonic-net#16547)
de60273 [Snappi] Infra changes for new PFC-ECN testcases. (sonic-net#13864)
7b357f5 [Snappi] New testcases for PFC-ECN. (sonic-net#13865)
3523a7f [Snappi]: PFC - Mixed Speed testcases (sonic-net#14122)
3754f2a sonic-mgmt: Fix namespace issues for qos tests on T2 single ASIC (sonic-net#15708)
21f6526 [sonic-net#16015 Fix]: Cleaning up unused code from snappi_fixtures (sonic-net#16026)
d8f23be Correcting client arguments to dynamically_compensate_leakout (sonic-net#16169)
3c47107 [sanity_check][bgp] Enhance sanity check recover for bgp default route missing (sonic-net#16357)
37352b8 Eliminate cross-feature dependency from macsec module (sonic-net#15617)
4f33b0d (pub_upstream/202405) [202405][dhcp_relay] Add test case to verify dhcp6relay LLA waiting logic (sonic-net#16494) (sonic-net#16567)
nnelluri-cisco pushed a commit to nnelluri-cisco/sonic-mgmt that referenced this pull request Mar 15, 2025
…onic-net#16026)

Description of PR
Summary: Removing unused fixtures: get_multidut_tgen_peer_port_set and
get_multidut_snappi_ports from snappi_fixtures.py
Fixes # (issue)
sonic-net#16015

Type of change
 Bug fix
 Testbed and Framework(new/improvement)
 Test case(new/improvement)
Back port request
 202012
 202205
 202305
 202311
 202405
Approach
What is the motivation for this PR?
How did you do it?
deleted the code

co-authorized by: [email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants