Revert macsec commmit b5348ce

[augusdn]

Currently, change introduced in commit b5348ce is causing macsec test to fail. This commit reverts the changes introduced in commit b5348ce.

Description of PR

Summary:
Currently, change introduced in commit b5348ce is causing macsec test to fail. This commit reverts the changes introduced in commit b5348ce.

On Cisco 8800, commit resulted in 2/10 pass ratio, while reverting the commit resulted in 12/16(had to run 4 consecutive times to check flaky tests), resulting in much higher passing rate.

Also the main reason for the reverting commit is that Cisco 8800 device is experiencing Port channel issue, where the status of Port channel on uplink LC remains Down after deploying mini-graph. While one PC comes back up, after initial macsec profile exchange, other remains down, and this will cause issue with sanity checks and bgp tests.

Type of change

• Bug fix
• Testbed and Framework(new/improvement)
• Test case(new/improvement)

Back port request

• 202012
• 202205
• 202305
• 202311
• 202405

Approach

What is the motivation for this PR?

How did you do it?

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

[judyjoseph]

Hi @augusdn We are building on the macsec pipeline for T2 on top of these changes, and macsec pipelines were passing 100% with dnx platform. Hence would need these changes

Please share the failure you see with portchannel. If it is flakiness will work to fix them - thanks

[judyjoseph]

@augusdn please refer this PR #16048 to do an add-topo, deploy_mg with the options " -e enable_macsec=True -e macsec_profile=MACSEC_PROFILE" in the command line. The changes in this PR will help to get the macsec sessions up and sanity should pass. Let me know if you face any issues - thx