-
Notifications
You must be signed in to change notification settings - Fork 737
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ECN probabilistic marking with PFC induced congestion #15909
Merged
yejianquan
merged 6 commits into
sonic-net:master
from
sreejithsreekumaran:ecn_xoff_quanta_variance
Dec 21, 2024
Merged
ECN probabilistic marking with PFC induced congestion #15909
yejianquan
merged 6 commits into
sonic-net:master
from
sreejithsreekumaran:ecn_xoff_quanta_variance
Dec 21, 2024
+282
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Test logs T0/T1
in T2
|
sreejithsreekumaran
changed the title
ECN probabilistic marking with with PFC induced congestion
ECN probabilistic marking with PFC induced congestion
Dec 9, 2024
@abdosi @amitpawar12 @selldinesh for review. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
renamed the function and file name
sreejithsreekumaran
force-pushed
the
ecn_xoff_quanta_variance
branch
from
December 20, 2024 10:35
46cf60c
to
57cc0b2
Compare
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
sdszhang
approved these changes
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 21, 2024
Description of PR Summary: Fixes # (issue) Approach What is the motivation for this PR? Add IXIA based test case to demonstrate ECN marking. The test will inject XOFF frame(s) to congest a queue that results in ECN marking. How did you do it? Using Snappi infra How did you verify/test it? setup continous traffic at 99.98% line rate with 1350B packets Test sends a single XOFF frame to the egress port to create congestion in the queue3. A pfc frame is sent with quanta set to values between 500 and 65000, one at a time - read the base ECN counter using serviceability CLI inject XOFF- read the ECN counters At the end of the iteration, once the data is collected, ensure that for each case, with increase in quanta, the marked count at index (n+1) is >= count observed with collection at index (n). Further if the marked count at index (n) > 0, verify that once marking happens, the marking probability increases with an increase in queue occupancy caused by increase in quanta co-authorized by: [email protected]
Cherry-pick PR to 202405: #16194 |
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
Add IXIA based test case to demonstrate ECN marking. The test will inject XOFF frame(s) to congest a queue that results in ECN marking.
How did you do it?
Using Snappi infra
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation