Don't exit warmboot-finalizer loop early due to SSH connection issue #15985
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In some cases, connecting to the device may fail for whatever reason. If this happens, the current code returns an empty string as the warmboot-finalizer state. There's a for-loop that exits when the warmboot-finalizer state is no longer active. An empty string being returned here breaks that. To avoid that, don't exit this loop if we get an empty string. Signed-off-by: Saikrishna Arcot <[email protected]>
saiarcot895
changed the title
Ryangwaite
approved these changes
Dec 11, 2024
bingwang-ms
approved these changes
Dec 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
In some cases, connecting to the device may fail for whatever reason. If this happens, the current code returns an empty string as the warmboot-finalizer state. There's a for-loop that exits when the warmboot-finalizer state is no longer active. An empty string being returned here breaks that.
How did you do it?
To avoid that, don't exit this loop if we get an empty string.
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation