-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Macsec profile deploy on peer VM's and DUT for macsec topo pipeline. #16048
Macsec profile deploy on peer VM's and DUT for macsec topo pipeline. #16048
Conversation
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
lgtm - can you also make sure to test with macsec not configured, to make sure that MG deploy works with non-macsec t2 topos. |
…add-topo/deploy-mg
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
tried it looks good |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
…etup in add-topo/deploy-mg" This reverts commit 548e6d6.
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. some comment for future enhancements
/azp run |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm. we need to handle in single asic LC in another PR
Approach
What is the motivation for this PR?
To run the macsec pipeline, the peer VM's and the local DUT should have the macsec config. These changes addresses those
Need to run the add-topo and deploy-mg with the options " -e enable_macsec=True -e macsec_profile=MACSEC_PROFILE"
How did you do it?
Following are the changes in this PR:
How did you verify/test it?
Verified the following commands work fine and macsec sessions comes up after deploy minigraph.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation