Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing HWSKUs to variables #16126

Merged
merged 1 commit into from
Dec 25, 2024
Merged

Conversation

wangxin
Copy link
Collaborator

@wangxin wangxin commented Dec 18, 2024

Description of PR

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • Test case(new/improvement)

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405

Approach

What is the motivation for this PR?

Not all HWSKUs are included in the variables file.
The missing HWSKUs frequently cause sync conflicts.

How did you do it?

This change added the missing HWSKUs to the variables file.

How did you verify/test it?

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

@wangxin wangxin requested a review from kevinskwang December 18, 2024 02:59
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wangxin wangxin requested a review from StormLiangMS December 18, 2024 03:00
kevinskwang
kevinskwang previously approved these changes Dec 18, 2024
Not all HWSKUs are included in the variables file.

The missing HWSKUs frequently cause sync conflicts.

This change added the missing HWSKUs to the variables file.

Signed-off-by: Xin Wang <[email protected]>
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@wangxin
Copy link
Collaborator Author

wangxin commented Dec 24, 2024

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Collaborator

@StormLiangMS StormLiangMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StormLiangMS StormLiangMS merged commit 26ae893 into sonic-net:master Dec 25, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants