[202405]Enhance advance reboot test (#15880) #16160
Merged
+24
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add more debug information to the advance reboot 1. Add more debug information 2. When get the dut time has exception, need to not break the get teamd state function 3. When get the finalizer_state, if the state is set to empty should not return. Change-Id: Ifb87ca9a5c7321cc632e100b8ceda759fa0ea804
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
nhe-NV
changed the title
roy-sror
reviewed
Dec 24, 2024
| @@ -1457,14 +1467,24 @@ def wait_until_teamd_goes_down(self): | |||
|
|
|||
| while teamd_state == 'active': | |||
| time.sleep(1) | |||
| dut_datetime_during_shutdown = self.get_now_time() | |||
| try: | |||
There was a problem hiding this comment.
would be better to define a new function - run_and_ignore_failure, as you use it more than once
| @@ -1003,8 +1003,14 @@ def check_warmboot_finalizer(self, finalizer_timeout): | |||
| self.finalizer_state = self.get_warmboot_finalizer_state() | |||
| self.log('warmboot finalizer service state {}'.format(self.finalizer_state)) | |||
| count = 0 | |||
| while self.finalizer_state == 'activating': | |||
| self.finalizer_state = self.get_warmboot_finalizer_state() | |||
| while self.finalizer_state != 'inactive': | |||
There was a problem hiding this comment.
why do we change the logic from ==activating to !=inactive ?
There was a problem hiding this comment.
why do we change the logic from ==activating to !=inactive ?
The is some chance that self.get_warmboot_finalizer_state() will return "" if the it some problem to access the dut
|
@bingwang-ms Can you help to merge this? this is to handle the confilict in 202405 for PR #15880 which was already merged |
bingwang-ms
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
cherry-pick for #1588
Type of change
Back port request
Approach
What is the motivation for this PR?
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation