-
Notifications
You must be signed in to change notification settings - Fork 740
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
generate 100000_300m pcbb qos test param for th2 #16232
Merged
kevinskwang
merged 1 commit into
sonic-net:master
from
XuChen-MSFT:xuchen3/master/th2-pcbb-100000_300m-qos-param
Dec 27, 2024
Merged
generate 100000_300m pcbb qos test param for th2 #16232
kevinskwang
merged 1 commit into
sonic-net:master
from
XuChen-MSFT:xuchen3/master/th2-pcbb-100000_300m-qos-param
Dec 27, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Xu Chen <[email protected]>
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
lolyu
approved these changes
Dec 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
kevinskwang
approved these changes
Dec 27, 2024
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 27, 2024
Signed-off-by: Xu Chen <[email protected]>
mssonicbld
pushed a commit
to mssonicbld/sonic-mgmt
that referenced
this pull request
Dec 27, 2024
Signed-off-by: Xu Chen <[email protected]>
Cherry-pick PR to 202411: #16250 |
Cherry-pick PR to 202405: #16251 |
This was referenced Dec 27, 2024
mssonicbld
pushed a commit
that referenced
this pull request
Dec 27, 2024
Signed-off-by: Xu Chen <[email protected]>
mssonicbld
added
Included in 202405 branch
and removed
Created PR to 202405 branch
labels
Dec 27, 2024
mssonicbld
pushed a commit
that referenced
this pull request
Dec 28, 2024
Signed-off-by: Xu Chen <[email protected]>
mssonicbld
added
Included in 202411 branch
and removed
Created PR to 202411 branch
labels
Dec 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
encountered KeyError: '100000_300m' when run test_xoff_for_pcbb test fro 202405 branch
How did you do it?
run tests/qos/files/brcm/qos_param_generator.py to auto generate qos parameter for xoff case, and copy param to qos.yml for pcbb case.
How did you verify/test it?
applied new 100000_300m param, and ran pcbb testcase. passed test.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation