-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Transition multi_asic_t1 PR checker to impacted area-based PR checker #16789
Merged
yejianquan
merged 3 commits into
sonic-net:master
from
yutongzhang-microsoft:yutongzhang/change_multi_asic_t1
Feb 7, 2025
Merged
Transition multi_asic_t1 PR checker to impacted area-based PR checker #16789
yejianquan
merged 3 commits into
sonic-net:master
from
yutongzhang-microsoft:yutongzhang/change_multi_asic_t1
Feb 7, 2025
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
BYGX-wcr
approved these changes
Feb 6, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks Good
yejianquan
approved these changes
Feb 7, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
In this PR, we transition the multi_asic_t1 PR checker to impacted area-based PR checker, enabling automatic selection of test scripts using pytest marks.
Summary:
Fixes # (issue)
Type of change
Back port request
Approach
What is the motivation for this PR?
In this PR, we transition the multi_asic_t1 PR checker to impacted area-based PR checker, enabling automatic selection of test scripts using pytest marks.
How did you do it?
Transition the multi_asic_t1 PR checker to impacted area-based PR checker,
How did you verify/test it?
Test by pipeline itself.
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation