Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transition multi_asic_t1 PR checker to impacted area-based PR checker #16789

Conversation

yutongzhang-microsoft
Copy link
Contributor

@yutongzhang-microsoft yutongzhang-microsoft commented Feb 5, 2025

Description of PR

In this PR, we transition the multi_asic_t1 PR checker to impacted area-based PR checker, enabling automatic selection of test scripts using pytest marks.

Summary:
Fixes # (issue)

Type of change

  • Bug fix
  • Testbed and Framework(new/improvement)
  • New Test case
    • Skipped for non-supported platforms
  • Test case improvement

Back port request

  • 202012
  • 202205
  • 202305
  • 202311
  • 202405
  • 202411

Approach

What is the motivation for this PR?

In this PR, we transition the multi_asic_t1 PR checker to impacted area-based PR checker, enabling automatic selection of test scripts using pytest marks.

How did you do it?

Transition the multi_asic_t1 PR checker to impacted area-based PR checker,

How did you verify/test it?

Test by pipeline itself.

Any platform specific information?

Supported testbed topology if it's a new test case?

Documentation

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yutongzhang-microsoft yutongzhang-microsoft changed the title Change multi_asic_t1 PR checker to impacted area Transition multi_asic_t1 PR checker to impacted area-based PR checker Feb 6, 2025
@yutongzhang-microsoft yutongzhang-microsoft marked this pull request as ready for review February 6, 2025 08:06
Copy link
Contributor

@BYGX-wcr BYGX-wcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good

Copy link
Collaborator

@yejianquan yejianquan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yejianquan yejianquan merged commit 21e49f9 into sonic-net:master Feb 7, 2025
17 checks passed
@yutongzhang-microsoft yutongzhang-microsoft deleted the yutongzhang/change_multi_asic_t1 branch February 7, 2025 02:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants