feat: enable T2 auto health check #16825
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lerry-lee
reviewed
Feb 10, 2025
Comment on lines
-221
to
-228
| # TODO: Refactor the following code to specify a "leader" T2 Testbed and skip the check on "followers" | ||
| # Retrieve the basic facts of the DUTs | ||
| if self.is_multi_asic: | ||
| errmsg = "Not support to perform checks on multi-asic DUT now." | ||
| logger.info(errmsg) | ||
|
|
||
| raise SkipCurrentTestbed(errmsg) | ||
|
|
There was a problem hiding this comment.
If we remove this skip logic, will multi_asic Testbed be affected? I remember previously multi_asic testbed can't run some ansible module(like get dut facts, bgp facts). I'm not quite sure.
There was a problem hiding this comment.
The multi_asic Testbed won't be affected. Please see the comment here: #15836 (comment)
lerry-lee
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Enable T2 auto health check and add running container info to return data.
Summary:
Fixes # (issue) Microsoft ADO 30293537
Type of change
Back port request
Approach
What is the motivation for this PR?
We want to enable T2 auto health check as we have now supported T2 auto recover.
How did you do it?
How did you verify/test it?
Any platform specific information?
Supported testbed topology if it's a new test case?
Documentation