Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update xcvrd.py to use DPTxTurnOn duration #365

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

rajann
Copy link
Contributor

@rajann rajann commented May 31, 2023

Description

Update CMIS fsm to use advertised DPTxTurnOn duration

Motivation and Context

CMIS state machine should make sure whether Truning on Laser is successful or not

How Has This Been Tested?

Stage an optics module that advertise the DPTxTurnOn duration information and bring up the interface.

Copy link
Contributor

@mihirpat1 mihirpat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rajann - Just wondering why are we not handling the case for DPTxTurnOff to wait for the relevant duration?

Copy link
Contributor

@mihirpat1 mihirpat1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems build is failing. Can you please help in addressing it?

@prgeor
Copy link
Collaborator

prgeor commented Jan 24, 2024

@rajann do you want to address this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants