Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[xcvrd] DPB support on platforms with CmisManagerTask enabled #500

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

[xcvrd] DPB support on platforms with CmisManagerTask enabled #500

wants to merge 3 commits into from
+122 −64

Commits on Oct 3, 2024

  1. fix(xcvrd): fix DPB support with CMIS transceivers 

    CmisManagerTask's `port_dict` and `port_mapping` must be updated
according to the port add/remove events.

Before this commit, `port_mapping` is only intialized when
CmisManagerTask is initialized and not updated after that,
which was causing KeyError exception when DBP is used.
(sonic-net/sonic-buildimage#18893)

This commit removes the `port_mapping` field from CmisManagerTask as
`port_mapping` was used just for storing `asic_id` information
and that can be simply done by `port_dict` instead.

Also, this commit updates `port_dict` accoding to the port add/remove
events to support DPB.

Signed-off-by: Wataru Ishida <[email protected]>
    @ishidawataru
    ishidawataru committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    8f79979 View commit details
    Browse the repository at this point in the history

  2. fix(xcvr): improve coverage 

    Signed-off-by: Wataru Ishida <[email protected]>
    @ishidawataru
    ishidawataru committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    6ef3822 View commit details
    Browse the repository at this point in the history

  3. fix(xcvrd): fix PORT_DEL handling due to xcvr plug-out 

    Signed-off-by: Wataru Ishida <[email protected]>
    @ishidawataru
    ishidawataru committed Oct 3, 2024
    Configuration menu
    Copy the full SHA
    954e9cb View commit details
    Browse the repository at this point in the history