[configdb.py] Fixed __raw_to_typed() api to return correct typed obje… #47
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ct when redis key is NULL(#277) Signed-off-by: madhu Pal <[email protected]>
This was referenced Jan 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ct when redis key is NULL(#277)
Signed-off-by: madhu Pal [email protected]
What I did
Fixed __raw_to_typed() api to return correct typed object when redis key is NULL.
How I did
As we store "NULL:NULL" as a placeholder for objects with no attributes, the __raw_to_typed() returns None, which causes get_entry() returns None for objects exists with no attributes.
To fix this issue - added code in __raw_to_typed() to return typed_data = {"NULL":"NULL"} when Key = NULL