[nvidia] Skip SAI discovery on ports on fast-boot #1416
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Given that modern systems have lots of ports, performing SAI discovery takes very long time, e.g. 8 sec for 256 port system. This has a big impact of fast-boot downtime and the discovery itself is not required for Nvidia platform fast-boot. Same applies to Nvidia fastfast-boot (aka warm-boot), yet needs to be tested separately. Signed-off-by: Stepan Blyschak <[email protected]>
stepanblyschak
force-pushed
the
skip-discovery-on-fast-boot
branch
from
aa63de0
to
995d79b
Compare
kcudnik
requested changes
Oct 2, 2024
kcudnik
reviewed
Oct 2, 2024
| @@ -89,7 +89,8 @@ namespace syncd | |||
|
|
|||
| virtual void onPostPortCreate( | |||
| _In_ sai_object_id_t port_rid, | |||
| _In_ sai_object_id_t port_vid) = 0; | |||
| _In_ sai_object_id_t port_vid, | |||
| _In_ bool discoverPortObjects = true) = 0; | |||
There was a problem hiding this comment.
this is very strict to ports, if we decide later on to do something similar on other objects then this is not optimal solution
kcudnik
reviewed
Oct 2, 2024
Comment on lines
+5304
to
+5308
| #ifdef SKIP_SAI_PORT_DISCOVERY_ON_FAST_BOOT | ||
| const bool discoverPortObjectsInFastBoot = false; | ||
| #else | ||
| const bool discoverPortObjectsInFastBoot = true; | ||
| #endif |
There was a problem hiding this comment.
fast boot cak be initiated after code was compiled which then this check will be hardcoded
There was a problem hiding this comment.
also there are no tests for testing this code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Given that modern systems have lots of ports, performing SAI discovery takes very long time, e.g. (8 sec) for 256 port system. This has a big impact of fast-boot downtime and the discovery itself is not required for Nvidia platform fast-boot.
Same applies to Nvidia fastfast-boot (aka warm-boot), yet needs to be tested separately.