fix SAI_ATTR_CONDITION_TYPE_AND for MANDATORY_ON_CREATE condition#1497
Draft
baorliu wants to merge 2 commits intosonic-net:masterfrom
Draft
fix SAI_ATTR_CONDITION_TYPE_AND for MANDATORY_ON_CREATE condition#1497baorliu wants to merge 2 commits intosonic-net:masterfrom
baorliu wants to merge 2 commits intosonic-net:masterfrom
Conversation
Signed-off-by: Baorong Liu <96146196+baorliu@users.noreply.github.com>
Collaborator
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
kcudnik
reviewed
Jan 10, 2025
| // this is conditional attribute, check if it's required | ||
|
|
||
| bool any = false; | ||
| bool all = true; |
Collaborator
There was a problem hiding this comment.
maybe it's time to use this https://github.com/opencomputeproject/SAI/blob/master/meta/saimetadatautils.h#L194
Collaborator
|
/azp run |
|
Azure Pipelines will not run the associated pipelines, because the pull request was updated after the run command was issued. Review the pull request again and issue a new run command. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
when check MANDATORY_ON_CREATE condition, the SAI_ATTR_CONDITION_TYPE_AND support is missing.