fix: resolve STP alignment warnings #43
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
omaaartamer
force-pushed
the
fix/alignment-warnings
branch
from
0193afa to
ce0fce8
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
- Replace packed attributes with proper alignment attributes - Fix potential unaligned memory access issues - Improve structure memory alignment for better performance - Resolve compiler warnings about packed member addresses The following structures were updated: - TIMER: aligned(4) - BRIDGE_BPDU_FLAGS: aligned(1) - BRIDGE_IDENTIFIER: aligned(4) - PORT_IDENTIFIER: aligned(2) - All BPDU structures: aligned(4) - Network header structures: properly aligned Testing: - Verified compilation with no alignment warnings - Tested on bullseye build environment - Confirmed proper BPDU handling
What: - Added padding fields to STP structures to ensure proper memory alignment - Modified PORT_ATTR, VLAN_ATTR, STP_PORT_CONFIG_MSG, and STP_VLAN_MEM_CONFIG_MSG How: - Added uint16_t padding to PORT_ATTR - Added uint8_t padding[3] to VLAN_ATTR - Added uint16_t padding to STP_PORT_CONFIG_MSG - Added uint8_t padding to STP_VLAN_MEM_CONFIG_MSG - Set all structures to __attribute__((aligned(4))) Why: - Fixes compiler warnings about packed member access - Ensures proper CPU memory alignment for better performance - Prevents potential issues with unaligned memory access - Improves code maintainability by removing warnings
omaaartamer
force-pushed
the
fix/alignment-warnings
branch
from
ce0fce8 to
eedb772
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix Structure Alignment Issues in STP Module
Problem
During SONiC image build on Broadcom platform (bullseye), the STP module generates compiler warnings related to packed structure member access:
First set of warnings:
Second set of warnings:
Solution
Add proper padding and alignment to all STP structures:
Changes Made
First set of modifications:
Additional structure improvements:
Modified files:
Testing Done
✅ Verified compilation with no alignment warnings
✅ Tested specifically on bullseye build environment
✅ Build command: make target/debs/bullseye/stp_1.0.0_amd64.deb
✅ Confirmed proper BPDU handling
✅ Verified timer operations
✅ Tested protocol message handling
✅ No regression in STP functionality
Build Environment
Impact
Dependencies
Related Information
Signed-off-by: Omar Tamer [email protected]