Fix a bug to escape slash in binary_to_printable

Signed-off-by: Ze Gan <[email protected]>
sonic-net · Jul 12, 2023 · f4db021 · f4db021
1 parent 8f8d501
commit f4db021
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/common/stringutility.h b/common/stringutility.h
@@ -180,7 +180,7 @@ static inline std::string binary_to_printable(const void *buffer, size_t length)
         {
             if (c == '\\')
             {
-                printable.push_back('\\');
+                printable.push_back('\\\\');
             }
             else
             {

diff --git a/tests/stringutility_ut.cpp b/tests/stringutility_ut.cpp
@@ -101,7 +101,7 @@ TEST(STRINGUTILITY, binary_to_printable)
     EXPECT_EQ(swss::binary_to_printable(a.data(), a.size()), "\\x01\\x02\\x03\\xFF\\x04");
 
     std::array<std::uint8_t, 5> b{0x0, 'a', '\n', '\'', '\\'};
-    EXPECT_EQ(swss::binary_to_printable(b.data(), b.size()), "\\x00a\\n'\\");
+    EXPECT_EQ(swss::binary_to_printable(b.data(), b.size()), "\\x00a\\n'\\\\");
 
     EXPECT_EQ(swss::binary_to_printable(nullptr, 0), "");
 }