[202205][FlexCounters] Fixed orchagent crash issue#2395 #2939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Issue seen on platforms that are not supporting queue-watermark and pg counters. Signed-off-by: rajkumar38 <[email protected]>
|
@vadymhlushko-mlnx @prsunny |
vadymhlushko-mlnx
approved these changes
Oct 20, 2023
prsunny
approved these changes
Oct 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue seen on platforms that are not supporting queue-watermark and pg counters.
What I did
Cherry-pick fix for orchagent crash reported in #2935
Why I did it
Added checks to skip if max values for PG and queue are 0
How I verified it
Reloaded swss debian with fix and enable flex counters watermark and pg-drop
Details if related