Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[COPP:Yang-changes] Fix for config replace issues seen with COPP configurations #3473

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

Verma-Anukul
Copy link

@Verma-Anukul Verma-Anukul commented Aug 5, 2024

==> Issue:
config replace/yang-validation fails for COPP configurations.

==> Root cause:
• COPP's device initial config copp_cfg.json has missing yang mandatory leaf "trap_action" for "default" COPP_GROUP.
• "genetlink_name" & "genetlink_mcgrp_name" nodes are not added in sonic-copp.yang, which are used for "queue2_group1" in copp_cfg.json

==> Fix:
• In copp_cfg.json, mandatory leaf "trap_action" is added for "default" COPP_GROUP.

"COPP_GROUP": {
"default": {

  • "trap_action":"trap", <<< this node needs to be added
    "queue": "0",
    "meter_type":"packets",

• "genetlink_name" and "genetlink_mcgrp_name" leaves are added in sonic-copp.yang.

• DB Migration script is updated to upgrade the DB config automatically.

==> Tests :
Config replace ->
i. Config load copp_cfg.json
ii. Config save
iii. Config replace -> Ensure no error seen

Upgrade ->
i. Save config in build without the fix
ii. upgrade to build with changes and ensure configurations are reflected in new config_db.json

==> PRs :
Sonic-buildimage : sonic-net/sonic-buildimage#19817
Sonic-utilities : #3473
SONiC (docs) : sonic-net/SONiC#1773

Signed-off-by: Anukul Verma [email protected]

@Verma-Anukul Verma-Anukul changed the title Fix for config replace issues seen with COPP configurations [COPP:Yang-changes] Fix for config replace issues seen with COPP configurations Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant