Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PVST Feaute CLI support #3514

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bendrapubalareddy
Copy link

@bendrapubalareddy bendrapubalareddy commented Sep 2, 2024

**** Please hold on review, will remove this line once ready for review **********

Changes:
modified: clear/main.py
new file: clear/stp.py
modified: config/main.py
new file: config/stp.py
modified: config/vlan.py
modified: debug/main.py
new file: debug/stp.py
modified: scripts/fast-reboot
modified: scripts/generate_dump
modified: show/main.py
new file: show/stp.py
modified: sonic_installer/main.py
modified: tests/mock_tables/appl_db.json
modified: tests/mock_tables/config_db.json
modified: tests/mock_tables/state_db.json
new file: tests/stp_test.py

What I did

How I did it

How to verify it

Previous command output (if the output of a command-line utility has changed)

New command output (if the output of a command-line utility has changed)

Changes:
       modified:   clear/main.py
       new file:   clear/stp.py
       modified:   config/main.py
       new file:   config/stp.py
       modified:   config/vlan.py
       modified:   debug/main.py
       new file:   debug/stp.py
       modified:   scripts/fast-reboot
       modified:   scripts/generate_dump
       modified:   show/main.py
       new file:   show/stp.py
       modified:   sonic_installer/main.py
       modified:   tests/mock_tables/appl_db.json
       modified:   tests/mock_tables/config_db.json
       modified:   tests/mock_tables/state_db.json
       new file:   tests/stp_test.py

Signed-off-by: Balareddy Bendrapu <[email protected]>
@adyeung
Copy link

adyeung commented Sep 12, 2024

@bendrapubalareddy BRCM posted the original PVST code PR to the community back in 2019, what is the point of reposting the same? By 2024, the SONiC community has approved and agreed upon MSTP through the SONiC HLD review meetings and PENS WG. The design and scope of this approved MSTP will encompass the requirements of PVST. Reintroducing the PVST code PR at this juncture risks significant conflicts with the upcoming MSTP contributions from BRCM and xFLOW.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants