add support for sai debug generate dump #3556
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This update introduces support for the sai_dbg_gen_dump API, which is triggered by the show techsupport command within the generate_dump script. Currently, this API is only invoked in the vendor specific use case to avoid disrupting existing implementations for other vendors. It is recommended to adopt this new procedure for triggering sai_dbg_gen_dump and eventually phase out the standalone saisdkdump executable. By integrating this API directly within the process, we eliminate the need for a separate process, as not all SAI implementations will function correctly when the API is called from a different process other than syncd. Additionally, this change will reduce the system footprint by 70 MB, currently occupied by the saisdkdump executable. An auxiliary script "gen_sai_dbg_dump.sh" is also provided to generate the dump file directly without requiring the show techsupport command.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This update adds support for the sai_dbg_gen_dump API, enabling the generation of a debug dump file by the SAI when there is no SAI failure. For scenarios involving SAI failures, a separate flow called dump_on_sai_failure is available.
Currently, this API is only invoked in the vendor specific use case to avoid disrupting existing implementations for other vendors.
An auxiliary script "gen_sai_dbg_dump.sh" is also provided to generate the dump file directly without requiring the show techsupport command.
An HLD will be publish soon with all relevant PRs
What I did
How I did it
How to verify it
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)