Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX]tacacs max server return and same tacacs server return #3667

Open
wants to merge 9 commits into
base: master
Choose a base branch
from

Conversation

651477787
Copy link

@651477787 651477787 commented Dec 9, 2024

add tacacs server TACACS_MAXSERVERS

What I did

It is error of return when reach tacacs max server

How I did it

add fix value of tacacs max server, same as raduis server

How to verify it

test on our project when reached max server, then return error.

update tacacs and update raduis.

anyone can tell me, what to do in nextstep, then merger into master ?

add tacacs server  TACACS_MAXSERVERS
when reach the max , then return
update for ctx.failed
update aaa tacacs
@wby-2024
Copy link

It works fine.

@651477787 651477787 changed the title Update aaa.py of tacacs [FIX]tacacs max server return and same tacacs server return Dec 19, 2024
@651477787 651477787 marked this pull request as draft December 19, 2024 07:00
@651477787 651477787 marked this pull request as draft December 19, 2024 07:00
@651477787 651477787 marked this pull request as draft December 19, 2024 07:00
@651477787 651477787 marked this pull request as ready for review December 19, 2024 07:03
Copy link

@wby-2024 wby-2024 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approve
test on our project, it works ok

@651477787
Copy link
Author

651477787 commented Dec 19, 2024

@liushilongbuaa
hi professor liu
would help me review the MR, thanks

config/aaa.py Outdated Show resolved Hide resolved
config/aaa.py Outdated Show resolved Hide resolved
Remove whitespace in empty line and remove whitespace before :
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Copy link
Author

@651477787 651477787 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

update code

config/aaa.py Outdated Show resolved Hide resolved
config/aaa.py Outdated Show resolved Hide resolved
remove whitespace before:
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

use f-string in ctx.fail
@mssonicbld
Copy link
Collaborator

/azp run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@651477787
Copy link
Author

@liushilongbuaa

hi professor liu
I have fix the comments,
would help me review the MR, thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants