Delete TRSNCEIVER tables while config reload #3680
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
noaOrMlnx
force-pushed
the
delete_transceiver_tables_reload
branch
from
6620dc2 to
44c650d
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
@prgeor , Can you please review ? |
mihirpat1
approved these changes
Dec 17, 2024
dprital
approved these changes
Dec 18, 2024
noaOrMlnx
pushed a commit
to noaOrMlnx/sonic-utilities
that referenced
this pull request
Dec 23, 2024
|
@noaOrMlnx Will skip this PR for 202405 branch as it's considered as not a must-have fix. Please let me know for any concern. Thanks |
vvolam
pushed a commit
to vvolam/sonic-utilities
that referenced
this pull request
Jan 8, 2025
* Delete TRANSCEIVER tables while config reload
|
@dprital @noaOrMlnx Is this required only for breakout ports? |
|
@kperumalbfn This change is required to any system which doesn't contain all ports. |
|
Cherry-pick PR to 202411: #3726 |
mssonicbld
added
Included in 202411 Branch
and removed
Created PR to 202411 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did
Removed TRANSCEIVER tables while config reload / load minigraph is executed.
This code adds the option to reserve TRANSCEIVER_INFO table if xcvrd is being restarted. - https://github.com/sonic-net/sonic-platform-daemons/blob/0cb36447ebfda390d999df6516beac4c17315a7b/sonic-xcvrd/xcvrd/xcvrd.py#L2199
The fix introduced here comes to fix the issue that the table remains also after config reload / load minigraph, which may cause config DB and TRANSCEIVER_INFO table have different ports keys.
How I did it
Update config reload command to delete TRANSCEIVER tables: ["TRANSCEIVER_INFO", "TRANSCEIVER_STATUS", "TRANSCEIVER_PM", "TRANSCEIVER_FIRMWARE_INFO", "TRANSCEIVER_DOM_SENSOR", "TRANSCEIVER_DOM_THRESHOLD"]
How to verify it
Execute config reload and make sure TRANSCEIVER tables are deleted
Previous command output (if the output of a command-line utility has changed)
New command output (if the output of a command-line utility has changed)