Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

vim: less distracting Search highlight #59

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

clobrano
Copy link

@clobrano clobrano commented Oct 2, 2019

Current Search/Incsearach highlight sets the full background color to
yellow (common in the majority of colorscheme), but results in a
distracting highlight.

This PR proposes a less distracting highlight, using yellow as the
foreground color instead. Moreover, style bold and underline help
see the text in case of styled filetype (e.g. markdown or
programming languages).

Current
Screenshot from 2019-10-02 15-09-42

Proposed
Screenshot from 2019-10-02 15-11-14

Current Search/Incsearach highlight sets the full background color to
yellow (common in the majority of colorscheme), but results in a
distracting highlight.

This PR proposes a less distracting hightlight, using yellow for the
foreground color instead. Moreover style bold and underline help
distinguing the text in case of styled filetype (e.g. markdown or
programming languages).
Added the following highlights classes

* header, which is the same as the standard "Title" highlight target
* Quote
* Code
* Link
incsearch and search have the same hightlight, making it more hard
to distinguish the current selected string among the one matching
the search.

Use underline to hightlight the current selected element
When two or more buffers are open at the same time, the one without
the focus has a blue background which, being more visible, can make
the user think that this is the on-focus buffer, while it is not.

Attempt fix setting Pmenu colors to have the same bg color of the on
focus split buffer, while using a grayed fg color.
@gstokkink
Copy link

@abcinje could you take a look at this PR please? The current highlighting isn't that great, though the rest of the colours are superb!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants