-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[DO NOT MERGE] [2.3.2.r1.4] drm/msm/sde: fix watchdog vsync timer configuration #2025
base: aosp/LE.UM.2.3.2.r1.4
Are you sure you want to change the base?
[DO NOT MERGE] [2.3.2.r1.4] drm/msm/sde: fix watchdog vsync timer configuration #2025
Conversation
Fix the incorrect values for the watchdog vsync timer with proper hexadecimal values. Change-Id: Iddaf36018a7f6521f7da32349afd64c5ebe79060 Signed-off-by: Dhaval Patel <[email protected]> Signed-off-by: Lakshmi Narayana Kalavala <[email protected]>
... But beware: test that everything goes as expected before merging it! |
to anyone testing, please check if gpu rendering times show any change compared to without this pr (settings->developer options->profile gpu rendering) |
P.S.: you are looking for improvements OR no regressions. Tama needs a check as well. |
With this diff applied I get (on pioneer at least) a very laggy response and the following: [ 62.888145] [drm:_sde_encoder_phys_cmd_handle_ppdone_timeout:494] [sde error]enc25 intf1 pp:0 kickoff timed out ctl 0 cnt 1 koff_cnt 1 |
Great, this means that we have to change the TE configuration in DT...... we will :D |
I get less tearing with this change. G8141/maple/XZP (Single SIM) |
I also do not get the logs @pablomh has above. |
pioneer has much more severe lagging than yoshino. would explain the observed discrepancy. though it's not clear how nor why that discrepancy appears. |
Great to know. If the test on a dual-dsi device has succeeded, then it's confirmed. The breakage on pioneer is utterly stupid and just a configuration mess. I'll check tomorrow! P.S.: since you're there on this commit, can you check if the jitter still varies wildly, and if it's reduced now? |
@kholk if you mean me, the jitter varied wildly with and without this commit, unfortunately. |
Yes I was meaning you.... Btw, okay, at least there's less tearing...... |
Is this change still interesting or I should drop it? |
Fix the incorrect values for the watchdog vsync timer
with proper hexadecimal values.
Change-Id: Iddaf36018a7f6521f7da32349afd64c5ebe79060
Signed-off-by: Dhaval Patel [email protected]
Signed-off-by: Lakshmi Narayana Kalavala [email protected]