-
Notifications
You must be signed in to change notification settings - Fork 362
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[7.1.r1] drm/msm/sde: sde_hw_top: Fix UBWC version detection for SDM630 #2356
base: aosp/LA.UM.7.1.r1
Are you sure you want to change the base?
Conversation
SDM630 (and by extension 636/660 and probably 8998) don't seem to have a working UBWC version register, but the UBWC version is already specified in the DT and then read out by SDE, so let's make use of that instead. Signed-off-by: Konrad Dybcio <[email protected]>
|
||
if (!mdp || !m) | ||
return; | ||
|
||
/* force blk offset to zero to access beginning of register region */ | ||
c = mdp->hw; | ||
c.blk_off = 0x0; | ||
ubwc_version = SDE_REG_READ(&c, UBWC_DEC_HW_VERSION); | ||
/* 630 doesn't seem to have the UBWC version register */ | ||
//ubwc_version = SDE_REG_READ(&c, UBWC_DEC_HW_VERSION); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please, remove the line instead of commenting it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought keeping it for reference is okay, newer platforms have this feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is WIP code. The original below reads both the register in ubwc_version
and what was stored in DT as m->ubwc_version
. Seems like it's done on purpose, I doubt this is correct. @konradybcio What do they do on mainline?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FWIW, we can see in drivers/gpu/drm/msm/sde/sde_hw_catalog.h
:
* @ubwc_version UBWC feature version (0x0 for not supported)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@MarijnS95 on mainline the version is hardcoded per platform.
1aa2204
to
838a06e
Compare
SDM630 (and by extension 636/660 and probably 8998) don't
seem to have a working UBWC version register, but the UBWC
version is already specified in the DT and then read out
by SDE, so let's make use of that instead.
Please test on tama/kumano!
dmesg | sed 3000q | grep -i uwbc
should return nothing. In case it returns
Unsupported UBWC version 0xsomenumber
please paste the output here so that I can fix it up.